Skip to content

HCMFINOPS-251 Reviewed CLI commands and options#24

Merged
openshift-merge-bot[bot] merged 5 commits into
openshift-online:mainfrom
theute:HCMFINOPS-251
Jul 3, 2026
Merged

HCMFINOPS-251 Reviewed CLI commands and options#24
openshift-merge-bot[bot] merged 5 commits into
openshift-online:mainfrom
theute:HCMFINOPS-251

Conversation

@theute

@theute theute commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Here are the changes:

finops account add aws …              → finops config account add aws …
finops account add snowflake …        → finops config account add snowflake …
finops account list …                 → finops config account list …
finops account list-tags              → finops tag list
finops account add-tag                → finops tag add
finops account update-tag             → finops tag update
finops account list-ous               → finops aws list-ous
finops config default get             → finops config default get
finops config default set             → finops config default set
finops config snowflake oauth set     → finops config oauth-client set
finops cost get                       → finops account get-cost
finops snapshot list                  → finops snapshot list
finops report list                    → finops report list
finops report generate                → finops report create
finops snowflake query                → finops snowflake query
finops demo hello                     → (removed)

I also added a --verbose option (in a separate commit but same PR)

theute added 2 commits July 2, 2026 12:24
@theute
HCMFINOPS-251 Re-arranged the commands
646a60e
@theute
HCMFINOPS-251 Add --verbose tracing for API calls and external commands
4e811bd 
Introduce core/apilog and cli/extrace to log STS, Organizations, EC2,
RDS, and Cost Explorer operations when -v is set. Wire verbose context
through AWS commands and document global flags in README.
@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 2, 2026
@coderabbitai

coderabbitai Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Walkthrough skipped

File diffs could not be summarized.

🚥 Pre-merge checks | ❌ 6

❌ Failed checks (6 inconclusive)

Check name Status Explanation Resolution
No-Weak-Crypto ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Container-Privileges ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Sensitive-Data-In-Logs ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Hardcoded-Secrets ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Injection-Vectors ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ai-Attribution ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@theute theute marked this pull request as ready for review July 2, 2026 12:01
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2026
@openshift-ci openshift-ci Bot requested review from aweiteka and rhaparker July 2, 2026 12:01
@theute

theute commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@theute

theute commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai run pre-merge checks

@theute theute requested a review from rhoneyaa July 2, 2026 12:38
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
✅ Actions performed

Running Pre-merge checks. Results will be posted in the summary comment once complete.

@theute

theute commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai run pre-merge checks

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
✅ Actions performed

Running Pre-merge checks. Results will be posted in the summary comment once complete.

@theute

theute commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai run pre-merge checks

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
✅ Actions performed

Running Pre-merge checks. Results will be posted in the summary comment once complete.

@aweiteka

aweiteka commented Jul 3, 2026

Copy link
Copy Markdown

lgtm
The only one I'm not confident in is account get-cost. What about OUs, or ec2, or any other object? But considering that wouldn't be practical i think this is the best path.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2026
@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aweiteka, theute

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 09c6c14 into openshift-online:main Jul 3, 2026
7 checks passed
@theute

theute commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

lgtm The only one I'm not confident in is account get-cost. What about OUs, or ec2, or any other object? But considering that wouldn't be practical i think this is the best path.

I think OUs still relate to 'account' costs (multiple accounts) and EC2 appears in account breakdown by service...
We may have an "compute" as a noun...

There are definitely tradeoffs... I wanted to stay away something that would just replicate 'aws' CLI (aws ce cost-explorer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aweiteka aweiteka aweiteka approved these changes
@rhaparker rhaparker Awaiting requested review from rhaparker
@rhoneyaa rhoneyaa Awaiting requested review from rhoneyaa

Assignees

@aweiteka aweiteka

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theute @aweiteka